1. Osclass Forum
  2. Plugins
  3. PHP Notice in RingCaptcha Plugin

PHP Notice in RingCaptcha Plugin

Started by Traian, August 13, 2021, 5:56 pm

  • 1

Traian

PHP Notice in RingCaptcha Plugin

on :August 13, 2021, 5:56 pm #496

Hello Calin,


Please note that I've just installed and configured the RingCaptcha plugin v1.2.2 on Osclass 3.8.0, PHP 7.2.34, and got this warning in Debug:


Code: [Select]

PHP Notice: Undefined index: s_phone_mobile in \oc-content\plugins\ring_captcha\index.php on line 258


Can you please fix it?


Thanks!

calinbehtuk

Re: PHP Notice in RingCaptcha Plugin

on :August 13, 2021, 6:28 pm #497

That should not happen. That code is running when a user edit is an account. If that key is not in array , is not an original Osclass version.


The plugin is not working? How do you get this error, what exactly do you do? I just tested the edit user process and is working fine.

Traian

Re: PHP Notice in RingCaptcha Plugin

on :August 16, 2021, 4:07 pm #498

Steps to reproduce the issue:


  1. Download and install fresh  Osclass from here: https://osclass.calinbehtuk.ro/plugins/ad-management/osclass-rc_i64
  2. Activate Debug
  3. Install, activate and configure RingCaptcha v1.2.2
  4. Integrate and use it for the registration page user-register.php
  5. After registering, go at /user/profile and update the phone number.

Everything works but you get the notice:

[16-Aug-2021 14:52:16 Europe/Madrid] PHP Notice:  Undefined index: s_phone_mobile in \oc-content\plugins\ring_captcha\index.php on line 258


Setup:
PHP 7.2.34
Osclass v3.8.0.2
RingCaptcha v1.2.2

So it's the plugin that needs a fix.
Thanks!

calinbehtuk

Re: PHP Notice in RingCaptcha Plugin

on :August 16, 2021, 9:27 pm #499

That is just a notice. I cannot reproduce that notice, but the plugin is working fine. That notice will not affect the plugin's performance or usage. I will prepare an update that will hide that notice.

Traian

Re: PHP Notice in RingCaptcha Plugin

on :November 25, 2021, 2:59 pm #561

Hello,


Please note that I've got another PHP notice:

Code: [Select]
PHP Notice: Undefined index: status in \oc-content\plugins\ring_captcha\RingCaptcha.php on line 72


It happens when entering a wrong validation code at phone number update.


Osclass 3.8.0

Plugin 1.2.3
PHP 7.4.25


Thanks!

Traian

Re: PHP Notice in RingCaptcha Plugin

on :November 28, 2021, 10:14 pm #562

Quote from: Traian on November 25, 2021, 2:59 pm

Hello,


Please note that I've got another PHP notice:

Code: [Select]
PHP Notice: Undefined index: status in \oc-content\plugins\ring_captcha\RingCaptcha.php on line 72


It happens when entering a wrong validation code at phone number update.


Osclass 3.8.0

Plugin 1.2.3
PHP 7.4.25


Thanks!

Any feedback on this?

As you can see in this benchmark , even with error_reporting disabled, PHP notices and warnings have a performance impact.


Thanks!

calinbehtuk

Re: PHP Notice in RingCaptcha Plugin

on :November 28, 2021, 10:32 pm #563

Is jut a notice. The plugin will work fine. Most likely the ringcaptcha will not return that key.

Traian

Re: PHP Notice in RingCaptcha Plugin

on :November 29, 2021, 7:39 pm #564

So in this case, the real answer is: even though this issue creates performance overhead and can easily be fixed, I won't do it because -insert reason here-


With all do respect, we have paid for a premium product that has an issue.

It's like buying a brand new car that leaks a bit of oil. It still works fine, but you need to watch that from time to time...


Now back to the actual issue.

This "just a notice" is generated by user interaction (users will wrongly enter the verification code), which means that on a popular install where tens of users are accessing it, you will get tons of these notices.

But... Yeah:ermm:


Thanks!

  • 1
Subscribe
X

Subscribe!

Subscribe to get the latest listings, updates and special offers delivered directly in your inbox.